Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autopipeling for buffer function + added built in commands #1231

Merged
merged 8 commits into from
May 22, 2021

Conversation

adamnoakes
Copy link
Contributor

@adamnoakes adamnoakes commented Nov 3, 2020

A fix for #1228
Also came across #621 whilst looking into this, and realised similar issue could exist for commands created via createBuiltinCommand, i added a suggested addBuiltinCommand to fix this.

lib/commander.ts Outdated Show resolved Hide resolved
@adamnoakes
Copy link
Contributor Author

@ShogunPanda

@ShogunPanda
Copy link
Contributor

The PR LGTM to me, go on and file it!

@adamnoakes
Copy link
Contributor Author

The PR LGTM to me, go on and file it!

Ok great, i'll try get this PR ready in the next couple days

@adamnoakes adamnoakes marked this pull request as ready for review November 11, 2020 13:20
@adamnoakes adamnoakes changed the title Fix autopipeling for buffer function Fix autopipeling for buffer function + added built in commands Nov 11, 2020
@SimonWoolf
Copy link

This seems to have fallen through the cracks - @luin is anything holding up this PR from being merged? (It would also be useful for us). Thanks! 🙂

@artur-ma
Copy link

@luin anything new about it ?

@rahbaner
Copy link

Hi @luin , any update on this? A friendly ping

@luin luin merged commit abd9a82 into redis:master May 22, 2021
ioredis-robot pushed a commit that referenced this pull request May 22, 2021
## [4.27.3](v4.27.2...v4.27.3) (2021-05-22)

### Bug Fixes

* autopipeling for buffer function ([#1231](#1231)) ([abd9a82](abd9a82))
@ioredis-robot
Copy link
Collaborator

🎉 This PR is included in version 4.27.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@luin
Copy link
Collaborator

luin commented May 22, 2021

Sorry for the delay! I overlooked the notifications for this thread. Awesome works @adamnoakes & @ShogunPanda!

@rahbaner
Copy link

Hi @luin, thanks, I will try this change on Monday. Thanks @adamnoakes and @ShogunPanda

janus-dev87 added a commit to janus-dev87/ioredis-work that referenced this pull request Mar 1, 2024
## [4.27.3](redis/ioredis@v4.27.2...v4.27.3) (2021-05-22)

### Bug Fixes

* autopipeling for buffer function ([#1231](redis/ioredis#1231)) ([abd9a82](redis/ioredis@abd9a82))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants